Filip Petkovski

Results 281 comments of Filip Petkovski
trafficstars

If you are scraping KSM, you will know when the pod went away by looking at when `kube_pod_info` for the pod stops being reported.

Having the termination timestamp as a label would create extremely high cardinality, which is why it is not added to any of the metrics. For this we would need a...

Unfortunately I don't have capacity to work on this right now, I am primarily focused on the new engine. If no one has stepped up to tackle this, maybe we...

I am not sure I like where this rabbit hole is taking us :) What about adding validation here so that we can take the guesswork out: https://github.com/thanos-io/thanos/blob/main/pkg/receive/hashring.go#L289? That should...

I've opened https://github.com/thanos-io/thanos/issues/5719 to discuss some dedup improvements. If we make any changes to StoreAPIs, it would be nice to introduce them prior to v1 and avoid maintaining code for...

@GiedriusS @bwplotka this is ready for another round of review. I updated the PR description with the latest information.

There was one issue with pushdown which should be fixed now. Other CI failures are unrelated to the change.

Here is the alternative implementation which does the sort check [only in one place](https://github.com/thanos-io/thanos/pull/5742/files#diff-0ad997aca791b33bb03ff7a0ce7e1da12da474505e612f2764c72b064dfb5e6aR111), without relying on responses from stores: https://github.com/thanos-io/thanos/pull/5742. It's simpler to understand and maintain, and results are...

I guess this can be both a global setting as a binary arg, and a field in the `PrometheusSpec`.