Frankie Papa

> Can you explain what's the use case for this? The interface looks very unintuitive to me. I agree it's odd looking, but it's used in https://arxiv.org/abs/2306.08585 specifically in figure...

> Could you just add a CX gate controlled on the target of the original inequality target? Neither target will always be flipped from 0 to 1. So I don't...

This is a draft PR. I will split off the other pieces, but using this branch to show https://github.com/quantumlib/Qualtran/issues/686.

@anurudhp @mpharrigan I am finding that MultiControlX(symbolic n).controlled() is causing issues. This issue was linked in the build_call_graph function for MultiControlX with symbolic cvs - what's required to fix this?...

Awesome! That will unblock https://github.com/quantumlib/Qualtran/pull/1489. Equals.controlled breaks down to that case and is causing issues with the symbolic cost unit test.

- [ ] Style guide for function signatures - [ ] List of functions that are desired for a bloq (signature, build_composite_bloq, build_call_graph, etc.) - [ ] Writing unit tests...

> tests? I added a classical simulation test for ECAddR(). Any recommendations on what tests I should add for ECPhaseEstimateR()? Also, for the call graph should I include the XorK()...

@mpharrigan I'll spend some time today finishing the PR (more tests and fix the call graph for ECAdd). I was wondering if you think ECAdd should be split into sub-bloqs...

Broke into the following PRs: https://github.com/quantumlib/Qualtran/pull/1411 https://github.com/quantumlib/Qualtran/pull/1412 https://github.com/quantumlib/Qualtran/pull/1424 https://github.com/quantumlib/Qualtran/pull/1425 Will make separate new PR for ECWindowAddR

One more PR: https://github.com/quantumlib/Qualtran/pull/1477 Now that they are all merged this PR can be closed as all of it's pieces are merged.