ws-protocol icon indicating copy to clipboard operation
ws-protocol copied to clipboard

Improve cpp CMakeLists.txt

Open kyle-verdant opened this issue 1 year ago • 3 comments

Public-Facing Changes

Removes pointless INSTALL step inside CMakeLists.txt, sets the library to be explicitly static.

Description

Default for libraries in CMake is STATIC. Installation of static libraries is pretty pointless - if it's desired to key off of BUILD_SHARED_LIBS or similar, I recommend only installing if built as shared, use CMAKE_LIST_DIR to properly support add_subdirectory, and to rename LICENSE on install to FOXGLOVE_LICENSE or similar. This came up trying to use CPM to install (FetchContent would have similar issues)

kyle-verdant avatar Feb 21 '24 20:02 kyle-verdant

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 21 '24 20:02 CLAassistant

@kyle-verdant Some of the CI jobs are failing, could you look into these?

achim-k avatar Feb 27 '24 12:02 achim-k

I think we shouldn't remove the install lines no? That would break the cmake install target and will break the usage for ppl that are using this as a pure cmake project.

jlack1987 avatar Sep 06 '24 19:09 jlack1987