studio icon indicating copy to clipboard operation
studio copied to clipboard

Published 20 hours ago • verified publisher icon foxglove

Latching data platform player causes map layer to disappear

Open amacneil opened this issue 3 years ago • 6 comments

Description

I'm looking at this URL from data platform demo org.

For some reason, the map layer disappears for a few seconds from both old + new 3d panels when using latching player, after I hit play. The messages are showing fine in raw messages panel. Disabling latching player fixes the bug.

https://user-images.githubusercontent.com/637671/183517154-ccdb899e-644d-4f5e-b3cb-8bfcef2e7d6a.mov

  • Version: main
  • OS: web / macos
  • Data source (e.g. bag file, mcap file, rosbridge, ROS 1/2 native): data platform

amacneil avatar Aug 08 '22 21:08 amacneil

@amacneil is that layout linked in the request a team layout? I'm getting an error saying the layout cannot be found. Which org is this?

defunctzombie avatar Aug 09 '22 00:08 defunctzombie

It is just a personal layout. You can create one similar to what I had - all you have to do is add a 3d panel and enable some topics.

This is in the "james" demo org.

amacneil avatar Aug 09 '22 02:08 amacneil

Few things we've learned here:

  1. The request for "lookback" on the /tf topic is not returning the /tf message at the start of the time range (it is returning one prior to the start) even tho we know there is one at the start.
  2. There is some issue with playing from the start that doesn't include the /tf message that should be at the start.

A few related console and data platform tickets have come from this:

  • https://github.com/foxglove/console/issues/946
  • https://github.com/foxglove/console/issues/947

Part of the issue here seems to be that data lookback is not including the specific start time so we are ending up with a /tf frame that isn't the frame we want.

There's an additional issue here around why playback is not playing the next expected /tf message but I am waiting to look into that once we've resolved the API issues.

defunctzombie avatar Aug 09 '22 23:08 defunctzombie

This PR https://github.com/foxglove/studio/pull/4144 might address some parts of this. Some of this is specific to how our sample data is timestamped.

defunctzombie avatar Aug 16 '22 18:08 defunctzombie

@amacneil are you still able to reproduce this?

defunctzombie avatar Aug 17 '22 04:08 defunctzombie

Yes, still happens for me here.

amacneil avatar Aug 17 '22 05:08 amacneil

@amacneil We've landed the api and streaming fixes. I ran through this again and could no longer reproduce this issue. I am going to close this as fixed given the underlying fixes we landed. If you are still able to reproduce please re-open with what else I should look for when playing back the data.

defunctzombie avatar Sep 02 '22 22:09 defunctzombie