studio
studio copied to clipboard
[3D panel] Add utility to create markers for trajectory plots
User-Facing Changes new user script utility to create markers
Description example plotting several x/y coordinates on the 3D panel use case: plot robot trajectory (estimated vs ground truth etc)
trigger: workaround suggested on Slack until the Plot panel can support several x/y pairs on the same plot related feature request: #3989 but create_marker utility function is generic for other use cases as well
I committed the entire script I created for my use case. I understand that this creates several unsuccessful checks. I guess the intent is that only the utility function create_marker() is included in the PR? let me know if you prefer that / or seing the entire script in action and then cherry picking yourself!
screenshot of the resulting 'plot' on the 3D panel (beta) :
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open.
@ljburtz Sorry this slipped through and no one got assigned to review or provide feedback. If this is still something you think we should include in the app, my initial feedback is that we'd want to find a more generic script that avoids specific topics like /small_scout_1/rover_odometry_gt
. Also it appears that this utility is actually a full user script rather than a utility and should be re-worked into a utility unless I miss-understand the PR title and description.
Thanks @defunctzombie for following up.
it appears that this utility is actually a full user script rather than a utility
absolutely. the generic utility that I think would benefit people is just the create_marker() function -> useful factory function for the 3d plot panel in several use cases -> that create_marker() function required some reverse engineering of not well documented fields, thanks to help from foxglove devs on the slack channel
the above script is, as you said, not something to merge directly. I thought that you being able to see a full example would have a more clear idea of what to cherry pick / the use of that create_marker() function
If this is still something you think we should include in the app,
Yes this is the workaround our team is using to visualize robot trajectories, until the plot panel can support several x/y message pairs. (we may have talked about it together during Roscon in Kyoto)