studio icon indicating copy to clipboard operation
studio copied to clipboard

Make GlobalCss usable outside of <App>

Open defunctzombie opened this issue 3 years ago • 4 comments

User-Facing Changes

Description

A different approach to https://github.com/foxglove/studio/pull/3788 - the main takeaway is that we still have some Fluent? Or other context menus that need the body to have the correct fonts because that's where they put their overlays and don't wrap them with a theme provider.

Until we resolve that, we can't remove the fonts from the body. Once we can remove the fonts from the body, then we can remove the dependency on theme and allow GlobalCss to be opt-in outside of App.

image

defunctzombie avatar Jul 08 '22 23:07 defunctzombie

@2metres is my analysis on why we need the fonts in the body correct here? It is a fluent thing and that for mui we are ok cause mui puts its context menus under a theme provider?

defunctzombie avatar Jul 08 '22 23:07 defunctzombie

@defunctzombie I believe that is correct. MUI puts it's poppers just inside the root element whereas Fluent UI puts it in the body

2metres avatar Jul 14 '22 09:07 2metres

This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open.

github-actions[bot] avatar Oct 14 '22 00:10 github-actions[bot]

This PR's time will come. It waits as a reminder to me.

defunctzombie avatar Oct 14 '22 05:10 defunctzombie