studio
studio copied to clipboard
foxglove
Reduce install size by removing .map files from ASAR
We already upload these files directly to Sentry, they do not need to be in the app installation images as well. Map files take up two thirds of the uncompressed ASAR disk space.
Does this work? I think the rimraf happens too late - the package has already been created.
Doesn't this make it harder to use the in-app debugger?
Yea - for production builds. Dunno if I think this is worth the decrease in size for that loss (tho I guess we can always make local builds with the maps). I'd like to know what the decrease in final app size is before we decide on this.
Where did we land on this? Maybe not enough benefit for the tradeoff for now?
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open.
@jtbandes @jhurliman thoughts on pushing this over the finish line? Seems like we don't do a lot of stepping through the code with users and we already upload maps to sentry (as stated in the issue) so maybe its worth the decrease in bundle size to merge this?
I think this is a good idea still, but don't have enough knowledge of the build steps to properly implement it.
Here's some actual numbers from my Mac OS build:
| Item | W/ .map files Size | No .map files Size |
|---|---|---|
| Size of Foxglove Studio Dev.app | 526M | 423M |
| Size of app.asar | 166M | 72M |
This PR has been marked as stale because there has been no activity in the past 3 months. Please add a comment to keep it open.