mcap icon indicating copy to clipboard operation
mcap copied to clipboard

bump binrw to `0.11` on mcap rust bindings

Open therishidesai opened this issue 1 year ago • 5 comments

When using the latest versions of binrw the mcap rust bindings fail to build with the following error:

121 |     fn read_le<T: BinRead>(&mut self) -> BinResult<T>
    |                   ^^^^^^^ required by this bound in `BinReaderExt::read_le`

error[E0277]: the trait bound `MessageHeader: binrw::BinRead` is not satisfied
   --> /home/rishi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mcap-0.6.0/src/read.rs:423:74
    |
423 |             let header: records::MessageHeader = Cursor::new(header_buf).read_le()?;
    |                                                                          ^^^^^^^ the trait `binrw::BinRead` is not implemented for `MessageHeader`
    |
    = help: the following other types implement trait `binrw::BinRead`:
              ()
              (b1, b2, b3, b4, b5, b6, b7, b8, b9, b10, b11, b12, b13, b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b10, b11, b12, b13, b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b11, b12, b13, b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b12, b13, b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b13, b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b14, b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
              (b15, b16, b17, b18, b19, b20, b21, b22, b23, b24, b25, b26, b27, b28, b29, b30, b31, b32)
            and 46 others
note: required by a bound in `read_le`
   --> /home/rishi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/binrw-0.9.2/src/binread/mod.rs:121:19
    |
121 |     fn read_le<T: BinRead>(&mut self) -> BinResult<T>
    |                   ^^^^^^^ required by this bound in `BinReaderExt::read_le`

error[E0433]: failed to resolve: use of undeclared type `McapString`
   --> /home/rishi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mcap-0.6.0/src/records.rs:212:17
    |
212 |         let k = McapString::read_options(reader, ro, args)?;
    |                 ^^^^^^^^^^ use of undeclared type `McapString`

error[E0433]: failed to resolve: use of undeclared type `McapString`
   --> /home/rishi/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mcap-0.6.0/src/records.rs:213:17
    |
213 |         let v = McapString::read_options(reader, ro, args)?;
    |                 ^^^^^^^^^^ use of undeclared type `McapString`
  • Version:
  • Platform:

Steps To Reproduce

cd mcap/rust
cargo run --example mcapcat

Expected Behavior

therishidesai avatar May 30 '23 19:05 therishidesai