mcap icon indicating copy to clipboard operation
mcap copied to clipboard

Published 20 hours ago • verified publisher icon foxglove

Make zstd optional in Rust library

Open foxymiles opened this issue 2 years ago • 5 comments

Public-Facing Changes Makes zstd an optional dependency for the Rust library.

Description This makes it possible to build the Rust library without built-in zstd compression support. The default build will still include it.

Note this also required adding an uncompressed version of the demo.mcap test data because when the Rust code is compiled without zstd it is unable to read the existing demo.mcap for test purposes.

Fixes #648

foxymiles avatar Oct 12 '22 15:10 foxymiles

Note - this doesn't seem to reduce the binary size by very much.

foxymiles avatar Oct 12 '22 19:10 foxymiles

Would we be interested in doing a similar feature flag for lz4 in a subsequent PR?

mrkline avatar Oct 16 '22 04:10 mrkline

@mrkline It seems like it would be similarly straightforward to also make lz4 optional, right?

foxymiles avatar Oct 17 '22 11:10 foxymiles

@foxymiles yeah, absolutely!

mrkline avatar Oct 17 '22 19:10 mrkline

@james-rms Ok to merge now?

foxymiles avatar Oct 17 '22 21:10 foxymiles