etherpad-plugins icon indicating copy to clipboard operation
etherpad-plugins copied to clipboard

Special html characters are not masked in headers

Open eviltel opened this issue 11 years ago • 6 comments

Used versions

  • headings 0.1.6
  • etherpad-lite 1.3.0
  • Debian Wheezy (7.2) with abiword 2.9.2

Problem

If a line has been processed with headings, special html characters have not masked. This is a problem if you want to export your pad to for ex. pdf. Abiword will not load the html file with a HTML parser error.

Using these example lines as headings do not work:

You & I
This is <Paul>

These lines in style Normal this means without headings processing will be exported without a problem.

eviltel avatar Oct 27 '13 16:10 eviltel

I can confirm this bug, cf. https://github.com/ether/etherpad-lite/issues/189#issuecomment-67142682

andreasBihlmaier avatar Dec 16 '14 11:12 andreasBihlmaier

TLDR to replicate:

  • Create a new pad with content Hello & world
  • Make this line H1

Attempt to export PDF through Abiword, Export will fail.

Please confirm.

JohnMcLear avatar Dec 16 '14 12:12 JohnMcLear

This is actually resolved but it appears @fourplusone hasn't pushed a version to npm with the fix in... https://github.com/fourplusone/etherpad-plugins/commit/8b983c78aced65d057822744433c3f0267d51e10 includes the fix.

JohnMcLear avatar Dec 16 '14 13:12 JohnMcLear

This fix is included in ep_headings2

JohnMcLear avatar Dec 28 '14 17:12 JohnMcLear

@JohnMcLear its currently not in ep_headings2. Could you please include it?

neffs avatar Feb 18 '15 02:02 neffs

@neffs done.

JohnMcLear avatar Feb 18 '15 02:02 JohnMcLear