Cyril Fougeray

Results 21 comments of Cyril Fougeray

@TheButlah let's resolve the conflicts and merge

IMO to go even further, I think `directory` should point to the location of the west top dir not: > .west is created next to "directory" but > .west is...

@pdgendt tox fails with errors even on `main` on my machine 😞

here is the manifest ``` manifest: remotes: - name: worldcoin url-base: [email protected]:worldcoin defaults: remote: worldcoin group-filter: [+internal] projects: - name: orb-firmware revision: ... import: name-allowlist: - zephyr - ... path:...

the problem is that is creates the `.west` directory inside `orb/` I want it to be at the top directory above ``` root@73b74a36d5cc:/home/ubuntu/firmware# west init -l orb/private --mf west.yml ===...

the `.west` directory seems to be hardcoded to be `manifest_dir.parent` with `manifest_dir` being the `directory` passed with the `-l` argument https://github.com/zephyrproject-rtos/west/blame/361004d55f5b8300aa828456a046e1e54200c648/src/west/app/project.py#L275

something like that work best ``` diff --git a/src/west/app/project.py b/src/west/app/project.py index d5f4c70..a87c2b6 100644 --- a/src/west/app/project.py +++ b/src/west/app/project.py @@ -286,8 +286,10 @@ below. self.create(west_dir) os.chdir(topdir) self.config = Configuration(topdir=topdir) - self.config.set('manifest.path', os.fspath(rel_manifest))...

yes I expect more discussion and refactoring... because it's not clear how to use `directory` passed with `-l` IMO https://github.com/zephyrproject-rtos/west/pull/775

>> If I modify .west/config manually, to have path = orb/private, then it works. > To be clear, when you did that you ALSO changed file = west.yml to make...