orb-software icon indicating copy to clipboard operation
orb-software copied to clipboard

slot-ctrl: remove two lines of unsafe

Open TheButlah opened this issue 1 year ago • 3 comments

TheButlah avatar Sep 30 '24 22:09 TheButlah

is it really worth it? 🤔 it delegates the unsafe code to a third party crate but should we trust libc or rustix more?

Using libc like this causes issues on macOS :/

vmenge avatar Oct 01 '24 11:10 vmenge

is it really worth it?

Yes, long term I want to try to use rustix as much as possible.

I will eventually rewrite the Ioctl stuff using it. It provides good tools for Ioctl calls. See for example my PR to nusb: https://github.com/kevinmehall/nusb/pull/65

TheButlah avatar Oct 01 '24 18:10 TheButlah

Did you test it on an orb?

No, because the thing is the same function. But I can do that before merging.

TheButlah avatar Oct 01 '24 18:10 TheButlah

@TheButlah let's resolve the conflicts and merge

fouge avatar Nov 12 '24 09:11 fouge