roaster

roaster copied to clipboard

wildcard resolved first instead of current package

13

when looking for super type of a type we try to resolve the canonical name of that type. the issue is that we are trying to resolve wildcard imports before...

asafbennatan

java.lang.ClassCastException SingleMemberAnnotation to NormalAnnotation

10

Error adding a annotation value to @Generated ``` java.lang.ClassCastException: class org.eclipse.jdt.core.dom.SingleMemberAnnotation cannot be cast to class org.eclipse.jdt.core.dom.NormalAnnotation (org.eclipse.jdt.core.dom.SingleMemberAnnotation and org.eclipse.jdt.core.dom.NormalAnnotation are in unnamed module of loader 'app') at org.jboss.forge.roaster.model.impl.AnnotationImpl.setAnnotationValue(AnnotationImpl.java:615) at...

astubbs

fix: All user code input should be validated #199

4

You should not be able to pass in invalid code and get obscure errors like "index out of range" exceptions. I found one place for this but the code should...

astubbs

``` java.lang.IllegalArgumentException at org.jboss.forge.roaster._shade.org.eclipse.jdt.core.dom.AST.newName(AST.java:2420) at org.jboss.forge.roaster.model.impl.JavaSourceImpl.setPackage(JavaSourceImpl.java:625) at org.jboss.forge.roaster.model.impl.JavaSourceImpl.setPackage(JavaSourceImpl.java:53) ``` setPackage should do a notBlank check on user input and throw contextual exception (same for all user input methods)

astubbs

You should not be able to pass in invalid code and get obscure errors like "index out of range" exceptions. I found one place for this but the code should...

astubbs

ROASTER-1: Java Statement Fluent Model

22

Update Copyright

sotty