Folkert de Vries

Results 189 comments of Folkert de Vries

> Does the feature not intend to go further than that? Again, I'm just saying "btw, here are my ideas for implementing the more complete version of this". Current state...

@rustbot ready Or at least, I hope I've answered the questions? Otherwise I don't think there are any actions for me?

Hey, I'm not sure what your process is, do you have some mechanism to make sure this doesn't just sit here forever?

I don't think this idea works because of this LLVM issue I opened https://github.com/llvm/llvm-project/issues/94463. So unless we can get that fixed (or somehow accept much worse codegen) this PR does...

@Jamesbarford given that you work at ARM, is there any chance you could pass this on to the right person (specifically the LLVM issue https://github.com/llvm/llvm-project/issues/94463). Not only does it clean...

I actually fixed https://github.com/llvm/llvm-project/issues/94463 in https://github.com/llvm/llvm-project/pull/140454. I just re-ran CI here to check if there are any other issues, and there were, resulting in https://github.com/llvm/llvm-project/issues/142323 and a fix in https://github.com/llvm/llvm-project/pull/142342....

@Amanieu this works now and is ready for review

@rtfeldman something to consider in the new `can` rewrite maybe. I think it's not implemented because of complexity, but better design can make it easier maybe?

ah, yeah. Well it'll probably get squashed before this is ready

I've made a proper tracking issue at https://github.com/rust-lang/rust/issues/140829