Folkert de Vries

Results 189 comments of Folkert de Vries

Can you get the input/output pair out for the misbehaving target?

Wait, did you already post the "bad" input/output somewhere? That's the interesting one really. Or is there a project/branch I can run to replicate? I'm on x86_64 linux. edit: nvm,...

You seem to deliberately ignore the `_consumed_out`, but I think that throws off the debug print here? I suspect that some of the data in the buffer is from earlier...

I'm increasingly sure that you're incorrect in ignoring `_consumed_out` there. The debug print shows that `_consumed_out` is just 24, but you print more bytes than that. From my testing, the...

Me and my impatience... Well, I'm happy to rebase this whenever to check whether things are working, and we'll see when everything is ready.

We've done a bunch of work here, and I believe all of the earlier review comments have now been dealt with. @rustbot ready

> > For one, I believe the static pattern-matching should use the const-eval interpreter instead of manually operating on valtrees. For two, it should not duplicate the work of match...

We've processed the latest round of review comments @rustbot ready

> I continue to be skeptical of the loop-match phrasing. I don't think "no new syntax" is a good argument with "well except it adds 2 new attributes and only...