Fabian Meumertzheim

Results 1695 comments of Fabian Meumertzheim

@tpasternak Are you using `--disk_cache` or `--remote_cache` when you reproduce this? I'm seeing some weird Skyframe invalidation when using these flags, but not without them. ``` Changed keys without new...

Possibly related: https://github.com/bazelbuild/bazel/issues/22367 @tpasternak Could you build Bazel with the patch I added to that issue and rerun on your reproducer?

Sorry for the lack of response, other efforts kept needing priority over the one. I'm planning to get back to it in April. @Algomorph If you really just want to...

> Could you at least update the branch via https://github.com/fmeum/bazel/pull/1? @aminya Sorry, I didn't want to merge it directly due to its size and then forgot about it. I just...

> @fmeum Please add docstring in `src/main/starlark/tests/builtins_bzl/cc/cc_static_library/test_cc_static_library/mock_toolchain.bzl` for `mock_cc_toolchain ` @iancha1992 Done. Despite the `src/main` prefix, this file is actually test code. Unless test code also requires doc strings, it...

> @comius WDYT? The internal CL is still blocked because of it. I added a doc string, do I need to do anything else to unblock it?

> > > @comius WDYT? The internal CL is still blocked because of it. > > > > > > I added a doc string, do I need to do...