Fabian Meumertzheim

Results 1695 comments of Fabian Meumertzheim

@SalmaSamy I just noticed that this would go away entirely with the new lockfile format as neither local registry contents nor any repo specs for Bazel modules are tracked in...

@DavidZbarsky-at Could you also test the performance with 7.0.0, which doesn't include https://github.com/bazelbuild/bazel/commit/e9022f6731b4f62d3a08bdc4eacce70ad28e3c78? Cc @oquenchil

@keertk Based on the slowdown reported in https://github.com/bazelbuild/bazel/issues/22309#issuecomment-2104697809 I would say yes, but I'll leave the decision to @oquenchil.

@DavidZbarsky-at Could you test https://github.com/bazelbuild/bazel/commit/b0ed4ca15d3c66fb7a5b19592cefaae709defe63? Pretty sure that fixes it.

This is the relevant line in rules_helm: https://github.com/abrisco/rules_helm/blob/main/helm/repositories.bzl#L130

@Wyverald Something we should keep in mind: When we update Bazel to build with 7.2.0, we might end up with extension repos missing from the lock file that we need...

The failing test (`testShowModuleAndExtensionReposFromBaseModule`) is pretty sensitive to any kind of changes to the spec builders, so you might have to adjust the number of skipped lines. Let me know...