Fabian Meumertzheim
Fabian Meumertzheim
@linzhp Could you also check the sun of the durations? This PR making it worse is pretty unexpected... We can't do anything about the number of restarts unfortunately.
I would also avoid this. With Bzlmod, each version of Gazelle can declare which minimum version of rules_go it is compatible with. Without Bzlmod, version resolution is non-existent anyway, so...
I submitted https://github.com/bazelbuild/rules_go/pull/3818 to temporarily undo the deprecation until we figure out the Gazelle migration.
@ryanpbrewster @mering Are you seeing this as well? Would you be willing to look into this as a follow-up to https://github.com/bazelbuild/rules_go/pull/3761?
We have removed the warning temporarily in https://github.com/bazelbuild/rules_go/commit/8beaf2e7f24c5dbf1b21ef8d349e8814ebb46415 and will provide a way to apply default overrides in https://github.com/bazelbuild/bazel-gazelle/pull/1716.
I'm not sure whether we can really pull off a "Go SDK to action definition" automation. But maybe we could implement some kind of a diff test in rules_go that...
We generally don't want Gazelle to emit canonical repository names into BUILD files at all as that can break strict deps and go unnoticed for a long time. I see...
Sounds good, remaining comments are all just nits in changed code.
Agreed, let's merge this and as a follow-up: 1. Resolve the problem you mentioned. 2. Add docs to our Bzlmod guide.
Thanks for working on this large project!