Fabian Meumertzheim
Fabian Meumertzheim
@leovitch These failures should be fixed by https://github.com/bazelbuild/bazel/pull/16755. Once it has been merged, you can do a trivial amend of your commits and force push to trigger a rerun of...
Looks like this was caused by https://cs.opensource.google/bazel/bazel/+/e9022f6731b4f62d3a08bdc4eacce70ad28e3c78. Cc @oquenchil
The `renameTo` call isn't guaranteed to be atomic in all filesystem setups, so couldn't (at least in theory) two test actions both enter the `isTestAction` branch in ` takeStashedSandboxInternal` for...
> I thought it was always atomic within the same filesystem. In which filesystem types isn't it atomic? That does seem to be true for the `UnixFileSystem`, but the `JavaIoFileSystem`...
I think that there is a race, I'm just not sure whether it can arise in practice: If spawn #1 blocks on the `ConcurrentHashMap#put` call in https://cs.opensource.google/bazel/bazel/+/f05c9d0b8d32d29847d5b16af1e5f8c20d11f66d:src/main/java/com/google/devtools/build/lib/sandbox/SandboxStash.java;l=160, then it will...
> Ah yes, but would we have seen this error? From the error I'd say there was an entry in the map but it was actually null somehow. `Map#get` also...
@Wyverald Could you review this from the Bzlmod dev perspective? @tetromino Could you review this from the Bzlmod user perspective? I can also add full e2e tests if desired.
@Wyverald Friendly ping
CI is failing due to the missing Python toolchain registration.
@Wyverald Tests are passing now.