Philipp A.

Results 1384 comments of Philipp A.

what’s the `if t.TYPE_CHECKING` for? if it’s there in order to keep Sphinx from picking up all the alternative signatures, I think it might be possible to use this: https://github.com/tox-dev/sphinx-autodoc-typehints/blob/e9db2aaee73c6dfe466cde83ea502dc4c33c2fb6/src/sphinx_autodoc_typehints/patches.py#L20-L35

I think just getting the type inference in is already super valuable. Typing for code like this will start working, which is a huge part of all Holo* code: ```py...

Hi, looks like this isn’t finished yet, there are still syntax errors in the code. I can’t review this yet!

Good idea! However I’m concerned that the color maps aren’t visually comparable. - Did you think about adding a color bar instead, like for the [heatmap](https://scanpy.readthedocs.io/en/stable/generated/scanpy.pl.heatmap.html) - alternatively, I’d replace...

I’m super sorry that I didn’t write back. Yes, this is exactly what I was thinking!

Hi, please add a complete, reproducible example. I added a `TODO` to your code where steps are missing! Please also make sure the parameter docs apply: > The annotated data...

> Hahaha not even my boss dared to go that far. I will try to deliver them, thank you! Ha! I think the roles are a bit different here 😉...

> I still could not figure out why does mypy fail on the pre-commit.ci while passes on GHA. That's the reason I kept GHA. Because pre-commit creates isolated environments. You’d...

Starting with version 1.12, mypy supports this syntax: https://mypy.readthedocs.io/en/latest/changelog.html#support-python-3-12-syntax-for-generics-pep-695 I see an internal error, so it’s for sure a mypy bug though!

Seems like it’s either fixed on master or the “49 files” mypy checks are `docs` and stuff. No way it just succeeds.