Per Abich

Results 13 comments of Per Abich

But this change is not only needed in FileAction (the previous change) but also in ModuleAction

I think it might be a good idea to remove the Logger class and use Slf4j directly. Anyone who really needs a non-standard logger could just implement a slf4j log...

No, I don't think so. Sometimes a developer wants to inspect the requests sent to another app running on localhost and puts a proxy in between the two apps. Always...

> The release publishing scripts for [homebrew](https://github.com/apache/maven-mvnd/blob/master/build/publish-on-homebrew.sh) and [sdkman](https://github.com/apache/maven-mvnd/blob/master/build/publish-on-sdkman.sh) have to be adjusted as well. I'll have a look

Should the new flow only work for v2 of mvnd? or even for 1.0?

I am unsure about the changes in the homebrew-mvnd repo. I have locally tried to adapt, but I am unsure about the perl expressions needed. Can you help with those?

Please have a look at it again to see if it works correctly now. I have this as accompanying PR: https://github.com/mvndaemon/homebrew-mvnd/pull/17

I have tried to incorporate your changes. Does it look ok to you now?

Is there something I need to do before this can be merged?

> @flyhard could you please rebase your PR against latest master? done