maven-mvnd icon indicating copy to clipboard operation
maven-mvnd copied to clipboard

Adding mvnd for linux on docker on a mac.

Open flyhard opened this issue 9 months ago • 9 comments

I am trying to use mvnd in a devcontainer on a mac. There is no binary available to install. It is also missing from SDKMAN!

flyhard avatar Mar 08 '25 19:03 flyhard

This needs more, look at other workflow files, like release...

cstamas avatar Mar 08 '25 19:03 cstamas

The release publishing scripts for homebrew and sdkman have to be adjusted as well.

gnodet avatar Mar 13 '25 09:03 gnodet

The release publishing scripts for homebrew and sdkman have to be adjusted as well.

I'll have a look

flyhard avatar Mar 13 '25 09:03 flyhard

Should the new flow only work for v2 of mvnd? or even for 1.0?

flyhard avatar Mar 13 '25 09:03 flyhard

I am unsure about the changes in the homebrew-mvnd repo. I have locally tried to adapt, but I am unsure about the perl expressions needed. Can you help with those?

flyhard avatar Mar 13 '25 12:03 flyhard

Just keep on master (2.x) for now.

cstamas avatar Mar 13 '25 12:03 cstamas

Please have a look at it again to see if it works correctly now. I have this as accompanying PR: https://github.com/mvndaemon/homebrew-mvnd/pull/17

flyhard avatar Mar 25 '25 11:03 flyhard

I have tried to incorporate your changes. Does it look ok to you now?

flyhard avatar Apr 01 '25 07:04 flyhard

Is there something I need to do before this can be merged?

flyhard avatar Apr 23 '25 10:04 flyhard

@flyhard could you please rebase your PR against latest master?

cstamas avatar Sep 08 '25 15:09 cstamas

@flyhard could you please rebase your PR against latest master?

done

flyhard avatar Sep 09 '25 20:09 flyhard

~Thanks!~ Tak!

cstamas avatar Sep 09 '25 20:09 cstamas

Seems something is still needed here... there is a name conflict? Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

cstamas avatar Sep 09 '25 20:09 cstamas

@flyhard seems uploading of daemon logs are now conflicting...

cstamas avatar Sep 09 '25 20:09 cstamas

Really difficult for me to debug this since I cannot run the pipeline when I think I have fixed something

flyhard avatar Sep 11 '25 11:09 flyhard

Our env.OS variable strips the version which makes the builds generate conflicting names. I pushed a fix for that. I hope the release pipeline does not have the same issue - in line 119 it looks like we could have an issue.

flyhard avatar Sep 11 '25 12:09 flyhard

Can you post link to line 119? As for me that maps to irrelevant line (am looking at early-access.yml you modified).

cstamas avatar Sep 11 '25 12:09 cstamas

Sure: https://github.com/flyhard/maven-mvnd/blob/792635bb7e2efe6ca94d21d12d22cbb794356d61/.github/workflows/release.yaml#L119 I see we are uploading with the env.OS, so macOS 13 macOS 14 and macOS latest might collide

flyhard avatar Sep 12 '25 20:09 flyhard