dingir-exchange icon indicating copy to clipboard operation
dingir-exchange copied to clipboard

design: make codes related to Fluidex and codes not decouple better

Open lispc opened this issue 3 years ago • 6 comments

so dingir-exchange can be used by others more easily

lispc avatar Jun 27 '21 12:06 lispc

FYI: I've created an Etherum-less version of dingir exchange --> https://github.com/gcomte/dingir-exchange

gcomte avatar Aug 13 '21 21:08 gcomte

FYI: I've created an Etherum-less version of dingir exchange --> https://github.com/gcomte/dingir-exchange

Looks nice :D

0xmountaintop avatar Aug 16 '21 12:08 0xmountaintop

@gcomte you might also want to remove account table's l2_pubkey combine it as

[derive(sqlx::FromRow, Debug, Clone, Serialize)]
pub struct AccountDesc {
    pub id: i32, // TODO: i32 or i64?
    pub pubkey: String,
}

pubkey can be used to check singnature. you might wanna remove OrderCommitment and implement your own signature verification logic, for example: https://github.com/fluidex/dingir-exchange/issues/59#issuecomment-767395547

0xmountaintop avatar Aug 16 '21 13:08 0xmountaintop

// TODO(not urgent): we should move nonce/sig_verify to the rollup_state_manager process later?

lispc avatar Aug 17 '21 08:08 lispc

and make dingir-exchange more 'internal service'

lispc avatar Aug 17 '21 08:08 lispc

pubkey can be used to check singnature. you might wanna remove OrderCommitment and implement your own signature verification logic, for example: #59 (comment)

I just removed the user management altogether. We will take care of it with an external service.

gcomte avatar Aug 23 '21 09:08 gcomte