Carlos Garcia

Results 176 comments of Carlos Garcia

@osullivanchris We'd appreciate your input regarding the error state when the editor encounters a non-recoverable exception (see attached screenshots to the PR). For reference, I used a similar approach as...

> Did you evaluate what it'd take to put the processor(s) in the Mobile Gutenberg package versus the iOS app codebase? Nope, I haven't explored what would be needed for...

> There is a good reason for consolidating this code in Gutenberg. The app and the editor produce different results when handling uploads. > > Here's an example of `PostCoordinator`...

> There is one more variable: the server. I noticed that it modifies the `content` before saving. For example, it might end up removing redundant spaces between tag attributes. So,...

While testing this PR, I spotted the issue https://github.com/wordpress-mobile/WordPress-iOS/issues/22901. I'll take the opportunity to address it here.

I'm de-assigning myself from the issue as I'm not planning to tackle it in the short/mid-term.

> 👋 Hey @fluiddot, I'd like to pull in `trunk` on this PR as some time has passed. I _believe_ this patch resolves the conflict on `PostCoordinator.swift` but I'd like...

> It looks like a [unit test](https://buildkite.com/automattic/wordpress-ios/builds/22368#018f829d-0148-4593-86d4-bf37a8e7e60b/12213-12221) may be failing because the output changed. I'm only spotting a whitespace difference. > > @fluiddot do you think we're good to just...

> LGTM @fluiddot! Feel free to merge - I only shared some Swift styling thoughts. 🚀 Thanks @twstokes for reviewing and approving the PR 🙇 ! I've applied the suggestions...

After checking the Sentry events, seems it's more prone to happen on specific device families: TECNO and Infinix are the top two. On the other hand, I noticed that Sentry...