WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Improve performance of Cover block processor

Open fluiddot opened this issue 11 months ago • 6 comments

This PR follows the same approach taken in https://github.com/wordpress-mobile/WordPress-iOS/pull/22896 to improve the performance of Gutenberg processors. The overall improvement will be less significant in this case (that's why the PR is marked as Enhancement instead of Bug) mainly because the File block is used by fewer users than Image/Gallery blocks. Nevertheless, it will speed up the post-saving process.

To test:

Follow the testing instructions to cover the functionality related to the processors for the block:

Regression Notes

  1. Potential unintended areas of impact The block processors are only used when saving a post. No other area should be impacted.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) Manually tested saving a post with Cover blocks.

  3. What automated tests I added (or what prevented me from doing so) Unit tests of the Cover block have been updated.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

fluiddot avatar Mar 25 '24 16:03 fluiddot

1 Message
:book: This PR is still a Draft: some checks will be skipped.

Generated by :no_entry_sign: Danger

dangermattic avatar Mar 25 '24 16:03 dangermattic

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22898-67e3041
Version24.5
Bundle IDorg.wordpress.alpha
Commit67e3041968d41cd58e633463d53e30ff6b3bac47
App Center BuildWPiOS - One-Offs #9256
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 25 '24 16:03 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22898-67e3041
Version24.5
Bundle IDcom.jetpack.alpha
Commit67e3041968d41cd58e633463d53e30ff6b3bac47
App Center Buildjetpack-installable-builds #8300
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Mar 25 '24 16:03 wpmobilebot

While testing this PR, I spotted the issue https://github.com/wordpress-mobile/WordPress-iOS/issues/22901. I'll take the opportunity to address it here.

fluiddot avatar Mar 26 '24 12:03 fluiddot

I'm moving this to the next milestone since this is not a blocker, and the code freeze will be completed today.

irfano avatar Apr 01 '24 13:04 irfano

👋 Hey @fluiddot, I'm bumping this PR to 24.8 since it's code freeze day. If this PR needs to target 24.7, please target the release branch once it's been cut. Thanks!

momo-ozawa avatar Apr 15 '24 12:04 momo-ozawa