Brian Crowell comments

Results 6 comments of


                                            Brian Crowell

fetch-mock Response.body is not always a stream in Node.js

Workaround: ```javascript const stream = require('stream'); const _baseResponseBuilder = require('fetch-mock/cjs/lib/response-builder'); require.cache[require.resolve('fetch-mock/cjs/lib/response-builder')] = { ..._baseResponseBuilder, exports: (options) => _baseResponseBuilder({ ...options, Stream: stream }), }; const nodeFetch = require('node-fetch'); // and so...

FIX: fetch-mock Response.body is not always a stream

The CI check that shows failure if code is similar _in test cases_ is not fun.

FIX: fetch-mock Response.body is not always a stream

I've fixed all the issues I can find. I can't access the circleci tests to see what it's complaining about.

replace canonical representations used in diffs with something like util.format()

While you're at it, make sure the new formatter supports Map objects. Currently they always display as {}. A quick test shows: ``` > console.log(util.inspect(new Map([['thing', 2], ['place', 'five']]), {compact:...

TypeError: Cannot read property 'Code' of undefined

I received this error today during the outage, when handling a response from the Redshift API. The source is this generated function: ```javascript const loadQueryErrorCode = (output, data) => {...

KEY_OVER_1024_CHARS error with large indented blocks of comments

Might check it against my sample again. I don't think the main bug has been fixed yet.