flowerysong

Results 66 comments of flowerysong

I think it's far more astonishing that `ucl_object_fromstring()` is unsafe to use (I was certainly surprised.) Ultimately it's up to you, but POLA doesn't mean "never fix major bugs."

I called it "unsafe" because it destroys the integrity of the data that you hand it. We discovered this behaviour in a part of our program that reads in data...

I'm strongly against this suggestion; it changes the syntax in a backwards-incompatible way for very little gain. The current syntax already allows you to express your examples as single lines:...

I wrote one a while back (https://github.com/flowerysong/ansible-flowerysong.melange/blob/main/plugins/modules/aws_data_lifecycle_manager.py) but have never had the time to work on submitting it.

I don't have time to finish this right now and get it in shape for merging, but it can be done fairly easily with a custom filter: https://github.com/flowerysong/ansible-amazon.aws/commit/72f998ea5ba39ba078be517c205106fdf77f62fc

This is a very specific set of transformations and I don't see any way in which it would be generically useful, but feel free to do whatever. Since this isn't...

https://github.com/flowerysong/ansible-community.aws/commit/d48b9b9639e17de9bd50e6d9ac339f294b5e6952 might fix this, but tests for this module are disabled in CI and I probably won't get around to testing it manually any time soon.

If a `command` task doesn't make changes you should set [`changed_when: false`](https://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html#defining-changed) on it.

I can replicate this with 1.3.2 but not with master; I suspect it was fixed by https://github.com/ansible-community/ara/commit/7388229361022b2805fa0e9a636b827ed6583ca9 https://github.com/ansible-community/ara/blob/d9df520e02f84a6aeb95ec643c7009cbe48c4efa/ara/plugins/callback/ara_default.py#L338-L346 could do with being made more fault-tolerant; losing the playbook information when...

> There is probably no need to print the entire words "OK", "CHANGED", etc, because they take up a lot of width real estate. It's somewhat unfortunate that failed and...