Florian Goße

Results 39 comments of Florian Goße

@phucpnt I wrote a small function which automatically bind the injected dependencies to `this`. And if you use ngAnnotate you only need to define your dependencies as parameters of your...

@AkosLukacs Sure, if you minify your code without ngAnnotate it will break but application. But you should use strictDi and ngAnnotate.

I think we actually need notification settings per device/notification target. This way you can turn of the notifications on your phone but keep them for your browser.

The default in git of max line width is 50 for the subject and 72 chars for all other lines. It is described in [How to Write a Git Commit...

It looks like it's related to https://github.com/nextcloud/richdocuments/issues/1904.

That is a nice improvement. I think we can make it even better by utilizing GitHub Actions to run automated deployments. I've used `peaceiris/[email protected]` in another project to deploy automatically...

Thanks for your PR. Looks good. :) There is only one small thing which can make our examples just a little bit more consistent. I've commented it inline.

That sounds like an interesting idea. I haven't used Vue yet and don't know how it could work with this module. Maybe you can submit a PR for it.

For us it worked really well to upgrade to `react-intl@3`. We have applied the changes in the upgrade documentation and it run seamless afterwards in storybook. Do you have any...