Florian Hotze

Results 148 comments of Florian Hotze

Unfortunately I also don't have the rights at the core repo. @kaikreuzer Can you please move this issue?

When using %s as pattern, there will be no difference in behaviour, correct? In that case I’m fine with aligning the behaviour.

> All I request is that we ensure it is the same in both places. How or why that is enabled is not my concern. Absolutely agreed! When we introduce...

> If anyone starts working on this, also consider #3736. And this proposal should then be implemented in the same release to avoid having breaking changes two times. Better to...

> Maybe we should limit it to the InMemoryPersistenceService. As it is in RAM after a reboot it will be empty anyway. It makes sense to have a .removePersistenceData() as...

That still doesn't explain why you need a removeAllPersistedData. In case you really want to remove from persistence, a method removePersistedStates(Item, FilterCriteria) should be sufficient. In case you want to...

It would be „cleaner“ to rename it, but in case it causes too big user-facing breaking changes, I’d vote on not chancing it. Let’s check first whether it actually causes...

> Any breaking API change on that class would break their rules. Is renaming the class a breaking API change for them? Or only when methods (signatures) change?

In that case it’s probably best to leave it as it is.

@kaikreuzer I guess this has to be moved to openHAB core.