Florian Hotze

Results 148 comments of Florian Hotze

@mstormi When you add an option to install those, you could also add an option to install the openhab-js library from npm.

When I have some time, I will take a look into this. Then I can also add a option to add the openhab_rules_tools.

@mstormi Which menu section would you choose for adding openhab-js and openhab_rules_tools? „openHAB Related“ or „Optional Comments“? I don‘t have a strong opinion about that, but I would slightly prefer...

@mstormi I opened the PR just a few seconds ago.

> The only thing I have is once it's installed, it also needs to be a part of the upgrade process somehow. Good point, that is something I did not...

I am not sure about auto-installing. `openhab-js` is included in the JS Scripting Add-On by default, so the only reason to manually install it is to upgrade to a newer...

> It will be out of sync. I've not considered trying to keep it in sync with openHAB, but perhaps it makes sense to consider some sort of sync. When...

> My vote is for auto-install. Then again I agree it's more important than this that updates are automated. Auto-install for `openhab_rules_tools`. Auto-install for openhab-js doesn‘t make much sense, as...

This sounds good. We can get the current installed version with `npm list openhab_rules_tools --prefix /etc/openhab/automation/js/` and check for the recent version with two different methods: - Using `npm show...

@rkoshak Thanks for your detailed answer, I don't want to explain my current way of handling that at two places. Would be cool if you'd have a look at the...