Florian Klink

Do you really need ldd here? `ldd` [executes](http://klamp.works/2016/04/15/code-exec-ldd.html) the binary you're investigating. It doesn't respect the interpreter listed in the binary to execute. It considers `LD_LIBRARY_PATH` being set when running...

If we bump the requirement to Go 1.15, we could use `TempDir` from `testing` to get a temporary directory that's cleaned up after the test. If we don't, it requires...

I opened https://github.com/u-root/u-root/pull/1956, which addresses `ed25519_test.go`.

There's nothing guaranteeing the files are created again. Files might already exist from a previous run, might be in an older version etc. They don't need to be around at...

In that case, Isn't the operator creating two separate `CronJob` resources (`postgres-pgbackrest-repo1-{full,incr}`)? How would you describe concurrency with each other? I think `ConcurrencyPolicy` only is about jobs based on the...

@q3k can you address the review comment and rebase this PR?

This needs yet another rebase unfortunately.

I ran this with docutils 0.19, and got the following test failures: ``` =================================== FAILURES =================================== ____________________ test_docutils_roles[90-pep-reference] _____________________ file_params = ParamTestData(line=90, title='pep-reference', description='(`docutils.parsers.rst.roles.pep_reference_role`):', conten...g/dev/peps/pep-0000">\n PEP 0\n', index=8, fmt=) monkeypatch...

This was only me passing in docutils 0.19 after relaxing the version bounds in pyproject.toml, and running unit tests. I didn't do any manual testing.

Ugh, I took a closer look. These URLs are hardcoded in the `docutil_roles.md` fixture file in the repo. This means the fixtures need to be different, depending on which version...