sops icon indicating copy to clipboard operation
sops copied to clipboard

Published 20 hours ago • verified publisher icon getsops

cmd/sops: use --config in subcommands

Open q3k opened this issue 5 years ago • 9 comments

Currently that flag is not being used by subcommands (publish and updatekeys). This fixes that problem.

I'm not exactly sure how to go about testing this. Any ideas?

q3k avatar Oct 29 '19 15:10 q3k

@q3k Oh nice. Thank you for the patch! Would you mind pointing this PR at our develop branch?

In regards to testing, at the moment it looks like we don't have any functional tests for this, so if you'd like to add some that'd be great. Otherwise, I'd build this locally and confirm that it works with updatekeys and regular encrypt/decrypt options for now. It'll go through some testing before it's released.

ajvb avatar Oct 29 '19 19:10 ajvb

Just rebased against develop.

I would appreciate if you tested it locally for now, I might take a stab at some tests tomorrow (and either update this PR or send off a new one), but I can't promise anything.

q3k avatar Oct 29 '19 19:10 q3k

Is there anything else that is needed to get this merged?

/cc @ajvb

lucendio avatar Feb 06 '20 10:02 lucendio

@lucendio Yes, @autrilla's comment should be addressed and needs to be tested.

ajvb avatar Feb 11 '20 20:02 ajvb

@q3k can you address the review comment and rebase this PR?

flokli avatar Jun 08 '20 13:06 flokli

@flokli Apologies! I'll do this now.

q3k avatar Jun 21 '20 18:06 q3k

This needs yet another rebase unfortunately.

flokli avatar Aug 04 '20 20:08 flokli

@q3k would you mind rebasing another time, and signing off your commits? It would be really great to get this finally merged.

felixfontein avatar Dec 17 '23 15:12 felixfontein