Florian Diebold comments

Results 137 comments of


                                            Florian Diebold

Add `cfg(rust_analyzer)` to docs book?

I think we shouldn't encourage usage of it.

Inlining a method with an early return does not handle early return correctly.

So far the philosophy with these assists has not been to try to produce code that works perfectly as before. Wrapping the function in a lambda would make the code...

Inlining a method with an early return does not handle early return correctly.

That being said, wouldn't labeled blocks and `break` work to handle this?

live-update diagnostics

> Is there any reason preventing rust-analyzer from using nightly compiler APIs? There are reasons, yes -- we prefer rust-analyzer to build on stable with normal `cargo build` to make...

This already exists as an experimental diagnostic; you can enable it by setting `rust-analyzer.diagnostics.experimental.enable` to true. You might get some false positive errors though, which is why it's not enabled...

Why rust-analyzer doesn't work in [test] function?

I think @Wyvern might be missing rustc errors from check-on-save? @Wyvern do you have any non-default settings? In particular `rust-analyzer.checkOnSave.allTargets` or `rust-analyzer.checkOnSave.target`?

Why rust-analyzer doesn't work in [test] function?

Do you have `rust-analyzer.checkOnSave.allTargets` or `rust-analyzer.checkOnSave.target` set?