Florian Diebold comments

Results 137 comments of


                                            Florian Diebold

Memory leak when declaring a higher order function

The modeling of closures in Chalk's test framework is somewhat different from ours, and often it's not possible to reproduce issues with them, in particular if variables are involved. So...

Make `ModuleId` a tracked struct

What's the second bug?

Double use of widget ID with context menu on draggable area

That works, thanks!

Spurious failure to load a `.rs` file from `OUT_DIR`

The problem doesn't reproduce for me. I'm not sure the choice of target folder is actually the problem, considering the file _does_ exist :thinking: I assume restarting VSCode does not...

Rare ICE in cstore_impl.rs with proc macro

I don't really see how rust-analyzer could cause an ICE in rustc that can't be otherwise triggered. We're only running `cargo` as normal subprocesses. So this should still be reported...

spurious diagnostic: Variable `None` should have snake_case name

> As a side note this can't be the real problem regarding None as it is the only item from std::prelude that causes problems. It's just one of the more...

Command/Code Action to add all missing imports

We don't have a way of prompting the user when there are ambiguous imports, but apart from that I think we should have this. (We could even try to be...

Incomplete syntax handling for proc-macros produces invalid `TokenStream` with `{`/`}` chars as a `Punct` rather than a `Group`

It's not parser recovery; it's this: https://github.com/rust-lang/rust-analyzer/blob/5982d9c420d0dc90739171829f0d2e9c80d98979/crates/hir-expand/src/fixup.rs#L151-L161 (Original code by me, FIXME added by @Veykril and he's of course correct ;) )

'Move item' refactoring

Btw, I've been thinking a possible UI for this (within the constraints of LSP) could be a 'move item here' assist on `use` items... so you have something like ```rust...

'Move item' refactoring

(and another possibility in that 'toolbox' would then be an `inline import` assist to get rid of the reexport...)