Florian Bernd

Results 282 comments of Florian Bernd

I can confirm that this is a bug. The `CompositeAggregrationSource` serializes the "terms" property on top level: https://github.com/elastic/elasticsearch-net/blob/a61e8037635e3c91e8da38363ed67f4cde28600b/src/Elastic.Clients.Elasticsearch/_Generated/Types/Aggregations/CompositeAggregationSource.g.cs#L38-L39 but the `TermsAggregation` type does this again: https://github.com/elastic/elasticsearch-net/blob/a61e8037635e3c91e8da38363ed67f4cde28600b/src/Elastic.Clients.Elasticsearch/_Generated/Types/Aggregations/TermsAggregation.g.cs#L272-L273 This is a bug...

Hi @thebmo, could you please check if it's working for you in 8.13.1? This version is based on a completely revised code generator.

@thebmo Glad to hear that it's working now 🙂 Thank you as well for the example. This will indeed be useful to other users. This particular change is documented in...

Hi there! After the big 8.13 release I finally have some time to look into the open issues 🙂 Another possible solution would be to expose a `[RequestResponseConverter]` attribute similar...

Hi @gpetrou, thanks for your feedback. It would be nice if you could as well enter this in the provided form (if you did not already do that). Just to...

@stefannikolei 8.13 was shipped with breaking changes which were unavoidable. More about the reasons here: - https://github.com/elastic/elasticsearch-net/issues/8091#issuecomment-2059059297 - https://github.com/elastic/elasticsearch-net/issues/8091#issuecomment-2059155570 The patch releases 8.13.x fixed some unintentional breaking changes, but should...

Improving usability of the multisearch endpoint is definitely on my list. The initializer based approach works for now, but I agree it might be useful to support descriptors here as...

Hi @LionelVallet, does that bug still exist in 8.13.x?

Hi @LionelVallet, thanks for testing. It seems like the new generator solved the initial issue, but caused other issues: - The descriptor should implement `IStreamSerializable` (just like the plain request)...