Felix Halpaap

Results 34 comments of Felix Halpaap

I see that; I didn't fully think through that part about templates that are too short because I had my own checks in place while I was creating the templates....

That's a good point! I added it in the list above, and I also added a point that it would be nice to later be able to ask `lag_calc` (and...

1. Sounds like a great idea to have ´SparseEvent´ etc. for internal usage. I could see that it may be useful for some cases if it also contained ´SparseAmplitude´ and...

I had the impression that for several other steps where the location and network codes can be an issue, one has to manually modify them to a common name anyways...

Hi @cjhopp , sorry for the delayed answer - didn't see the thread. I totally agree that making it an opt-in/opt-out is a very good change to make things robust...

@calum-chamberlain From the current commits, it reads to me that you are right now intending to give one weight to each template, rather than weight each trace in the template...

tests fail due to Scipy 1.9.0; I was hoping that `scipy>=0.18,

Well, I have to admit that I didn't consider [Tribe._par_write](https://github.com/eqcorrscan/EQcorrscan/blob/master/eqcorrscan/core/match_filter/tribe.py#L319) as much; and indeed from what I can think of now it should work just as well, especially if we...

Thanks for the feedback; i'll move the trace-metadata to a json together with the previously existing template metadata. Will need to wait until late next week when I'm back from...

Yes, the detection time is set according to the earliest time in the template (i.e. the starttime of the earliest trace in the template) plus the shift required to move...