Alan Fleming
Alan Fleming
## Download button I found [this stackoverflow](https://stackoverflow.com/questions/61708701/how-to-download-a-file-using-ipywidget-button#62641240) post useful, noting it is only useful for relatively small files as it will hold the file in ram. ``` import ipywidgets import...
Thanks for having a look and the suggested change. Unfortunately I can't think of a simple way to set `border` to `None` by observing a `border_*` which would give a...
I was actually thinking about breaking links applied by the user when I wrote that. In your suggestion you've use `hold_trait_notifications` which I guess should prevent a broken link error...
@jtpio - There's a lot of changes in this code, but the jist of it is that I've adjusted it from a Python perspective to provide the features that I've...
I had a look at supporting older versions. With a few changes was able to get it to work with 3.10. But anything older than that require re-writing/removing of type...
Regarding creating a new session without a notebook. I'm wondering if the new session should be based around a document... Currently, the function `newSession` defined int utils.ts creates a new...
I have no issue with removing the option 'remove_trailing_slash' if it isn't required. It was provided because there were `.rstrip('/')` calls scattered about. The question I pose is - which...
The original `make_path_posix` contains quite a lot of strip protocol code in it. It also includes 'sep' as an argument implying it can work for an alternate os. I'd prefer...
@ap-- It looks like you've made some good changes. > PR https://github.com/fsspec/filesystem_spec/pull/1477 added string coercion to make_path_posix, causing the newly added tests [here](https://github.com/ap--/filesystem_spec/blob/8ef54b032077ad0814f95ce5160926cc8c4c9081/fsspec/implementations/tests/test_local.py#L589-L601) to > fail. I marked them as...
I'm happy with `2` . In `stringify_path` I suggest changing from ` isinstance(filepath, pathlib.Path)` to ` isinstance(filepath, pathlib.PurePath). `Path` is a subclass of `PurePath`. and would mean `PurePosixPath` and `PureWindowsPath`...