Edwin Xie
Edwin Xie
I've tried to pick up the ball to implement these changes here: https://github.com/flawedmatrix/etcd/tree/fix/17068 One question I had was whether we only wanted to set LocalAddr to an IP address, or...
Assigning to myself since I've been looking at this today.
/approve
Not very familiar with the tests, but do we need `deleteObjects` when we have `ensureObjectsDeleted`? Or is `deleteObjects` used in the BeforeEach just in case and not expected to be...
Thank you @ahrtr for the very thorough review. I've made the suggested changes to my PR.
Thanks all for the suggestions. I've made the changes, added more unit test cases and added some logging to `InferLocalAddr`.
Hi @ahrtr, I just rebased again to fix the merge conflict. Could you please take a look?
Hi @ivanvc, I've squashed the commits that were my contributions. Thanks.