Mike Dalessio

icon indicating a website link http://mike.daless.io/ icon indicating an email [email protected]

icon location New York City / New Jersey icon location Part-time OSS contributor, maintaining Nokogiri, Loofah, Rails::Html::Sanitizer, Mechanize, Sqlite3, and more in the Ruby ecosystem.

Results 767 comments of Mike Dalessio

Segfault in Citrus during toml-rb initialization with Ruby 3.0

Please note that this is a bug in Ruby 3.0.0-3.0.2. I've reported it upstream at https://bugs.ruby-lang.org/issues/18138 and submitted a PR to fix it at https://github.com/ruby/ruby/pull/4787 In the meantime, I'll submit...

Segfault in Citrus during toml-rb initialization with Ruby 3.0

See PR at #61

Segfault in Citrus during toml-rb initialization with Ruby 3.0

Note that the underlying issue is fixed in Ruby 3.0.3.

Support Net::HTTP::Persistent.write_timeout

@maurycy Thank you for submitting this! Looks good, but I'd like to make some time to do a deeper dive on the timeouts (the test coverage seems pretty thin for...

Support Net::HTTP::Persistent.write_timeout

@maurycy Since you emailed me directly let me respond here. Would you be willing to add test coverage to this PR that exercises the write timeout, either using the test...

Add option to turn off waiting for delay when following meta redirects and option to follow meta redirects < a given # of seconds

I agree, it would be nice to be able to modify this behavior. See #429 and #523 for examples of the confusion that can ensue.

XML::Schema#validate(filename) returns 0 errors for malformed documents

Investigating.

XML::Schema#validate(filename) returns 0 errors for malformed documents

This is still a valid bug, and we should probably figure out how to better handle this case.

XML::Schema#validate(filename) returns 0 errors for malformed documents

The above example does return an error if we call `#validate` on a `Document` ... but the error is "The document has no document element" which is actually returned by...

Deprecate use of non-namespaced XPath custom functions

Here's the plan I'd like to follow: Introduce, in v1.14, support for the `nokogiri:` namespace in the CRuby implementation. Introduce, in v1.15, a deprecation warning if custom functions are invoked...