Flávio Fearn

Results 273 comments of Flávio Fearn

****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅

****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅

> this is the first time I see this part of the code, but maybe we don't need to execute the handleProtocol function? it looks like maybe we'd only want...

> I'd say this is a good temp fix but I think we should spend more time investigating why the command is executing twice (I also hate bugs like this...

Now when using the client the Store will also use the `window.api` to launch or install the game, so this will make it more predictable and fix some edge cases.

> Note that we also need to test this PR with the store URLs pointing to store.hyperplay.xyz since it should be merged prior to the store PR yeah, good point,...

> Amazing job @flavioislima, cheers for finding a way for this. It was dam tricky 🙌 Yeah, actually using the window.api was Brett's idea and it works a lot better....

> Play button on the store page remains inaccessible after install is complete through the store page. > Yes, I am working on new changes to improve this communication between...

> Appreciate the clean up! > > I was only able to find a few remaining references to nile in the package.json ![image](https://private-user-images.githubusercontent.com/27568879/330620253-5970d2c8-6705-4717-b277-ef2a71ee2fd2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTU3NzI5NzEsIm5iZiI6MTcxNTc3MjY3MSwicGF0aCI6Ii8yNzU2ODg3OS8zMzA2MjAyNTMtNTk3MGQyYzgtNjcwNS00NzE3LWIyNzctZWYyYTcxZWUyZmQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTE1VDExMzExMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmNTIyZmM4OGMwYTdhZTFlOTc1ZTk4ZGRlOWJiMGExNjA4NjNhMjNlYjRhNzk4MjRmMzA1ZDM5MDU2NGFiZGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.P5diOMHmjXjmPRVXH7VQwkAMDECN0l36QPMfl2zCr-U) good catch!

A temporary solution to add while we investigate and implement that would be to add the Firefox button to the wallet import modal and show it as disabled with a...