Flavio Fernandes comments

Results 160 comments of


                                            Flavio Fernandes

Enhance EgressQoS CR as a generic QoS feature

/lgtm

CI flake: Admin net pol `TestNetworkPolicyV2Conformance` test attempting to use port already in-use

Also seen here: https://github.com/ovn-kubernetes/ovn-kubernetes/actions/runs/13335335491/job/37250566074?pr=4508

CI flake: shard-conformance timeout v2

Also seen here: https://github.com/ovn-org/ovn-kubernetes/actions/runs/11595885658/job/32287402188?pr=4755

Use ip mapped mac address for internal management port

/lgtm

Use ip mapped mac address for internal management port

flake in external-gateway lane which is not related to this PR: https://github.com/ovn-org/ovn-kubernetes/issues/4139

Question: brightness support

Hi @aderesh ! You are right, I can see now in the library that there is an `hsv` attribute: Ref: https://python-kasa.readthedocs.io/en/latest/smartbulb.html I think that can be integrated into mqtt2kasa for...

Question: brightness support

> I've just found #10 reference in the code. to be consistent, I'll use a separate "/brightness" topic for now. Still, would be curious to know you opinion ah. nice!...

Question: brightness support

Fixed in 0857455edd8f00803b4c4501f67c4242e4f52fa6 by @aderesh

add dockerfile and flow

Looks good, @aderesh . Why close it? Oh, we can use your fork; or I can give you collaborator access to this repo. Your call.

Doesn't work with aiomqtt 2.0.0

Thank you @normanr ! I merged in the temporary fix. Interestingly, I noticed that pip install on a python 3.7 is not picking up aiomqtt 2.0.0, which is probably why...