ovn-kubernetes icon indicating copy to clipboard operation
ovn-kubernetes copied to clipboard

Use ip mapped mac address for internal management port

Open jxiaobin opened this issue 1 year ago • 4 comments

What this PR does and why is it needed

Currently for management port of internal type, a randomly generated MAC address will be used, while for dpu case, the IP of management port will be mapped to mac address which in turn will be assigned to the port. This commit changes the behavior of internal management port to make it align with that of dpu backed management port.

Which issue(s) this PR fixes

None

Special notes for reviewers

None

How to verify it

Check mac address of interface ovn-k8s-mp0, make sure it in the pattern of 0a:58:mm:xx:yy:zz, where mm:xx:yy:zz is the hexadecimal form of management port's IP address.

Details to documentation updates

None

Description for the changelog

For management port of internal type, generate MAC address by mapping its IP address to hexadecimal form.

Does this PR introduce a user-facing change?

No

jxiaobin avatar May 13 '24 20:05 jxiaobin

Coverage Status

Changes unknown when pulling 070fbe82ecb14fc82c73bf49dafc19db52f00101 on jxiaobin:ip-mapped-mgmt-mac into ** on ovn-org:master**.

coveralls avatar May 30 '24 03:05 coveralls

/lgtm

flavio-fernandes avatar Jun 05 '24 15:06 flavio-fernandes

flake in external-gateway lane which is not related to this PR: https://github.com/ovn-org/ovn-kubernetes/issues/4139

flavio-fernandes avatar Jun 05 '24 15:06 flavio-fernandes

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or reach out to maintainers for code reviews or consider closing this if you do not plan to work on it.

github-actions[bot] avatar Sep 10 '24 01:09 github-actions[bot]