Petter Friberg
Petter Friberg
> About the `configure` api, I'm now leaning towards your first idea of allowing call on the router instance to re-configure all settings. Actually, it already works like this, except...
> I wouldn't expect things I've set up before to be changed as a side-effect of me changing the configuration of the router. Actually I would. At least when standing...
Since Django versions < 3.2 are not officially supported by Django any longer, perhaps we should drop all of those? (https://www.djangoproject.com/download/)
@vitalik is this something you would consider merging?
> Weird, `runserver` is ok. But operations like `django-admin migrate` fails... > > ``` > ninja.errors.ConfigError: Router@'/xxx/' has already been attached to API V1:1.0.0 > ``` This could probably be...
Ah, yeah. I've missed that `factory_parent` is part of the API
I guess this addition in the end is a shortcut/convenience method as/if the `LazyAttribute` approach becomes a bit verbose
I'm on your side and would say that intuition is the key here and regardless if one would branch on behaviour at the API:s top-level (i.e. two separate declarations ->...
When it comes to testing types and type annotations. I'd suggest: https://github.com/TypedDjango/pytest-mypy-plugins Although it's a `pytest` plugin, so those tests needs to be run with `pytest`. Should be possible to...
Also, I took the liberty of adding docs for the `default` argument, since I was fiddling around in those sections anyways. Hope you don't mind.