Felix Lange comments

Results 442 comments of


                                            Felix Lange

Adding the mandatory jsonrpc version identification

seriously guys, this should be pulled in

is there a way to callStatic func like in ethers js?

While we don't have this feature right now, there is a workaround: encode the call yourself, submit using `CallContract` with ethclient, and decode the result using `accounts/abi`.

eth/catalyst: move block commit into its own go-routine to avoid deadlock

@jwasinger please look at this again

eth/catalyst: move block commit into its own go-routine to avoid deadlock

Yeah sounds like something that should be fixed.

Website: fix chain config when start a private network

Seems the consensus here is not to change the text for now, even though it is outdated.

ipv6 address used as extip results in `127.0.0.1` being used

This should be fixed by #29801

Fix deadlock in 'SimulatedBeacon.loop'

Related: #29657

Fix deadlock in 'SimulatedBeacon.loop'

We're continuing the work in #29657 instead.

p2p/discover: fix bug in `checkNodesEqual`

I have investigated. The problem is that the network created in the test is very small, and thus the outcome of the lookup depends on whether the randomly chosen nodes...

beacon/engineclient: create engine API client wrapper

This should be in `beacon/` probably?