fivecut
fivecut
๐ฎ๐ป๐ฎ๐ป๐ฎ๐ป !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! ๐ฎ๐ป๐ฎ๐ป๐ฎ๐ป remove repeat words # PR Checklist: -...
# Description make function comment match function names ## Type of change - Docs # How has this been tested? - [ ] Test A - [ ] Test B...
## General Changes fix some comments ## Developer Notes Add any notes here that may be helpful for reviewers. --- ## Author Checklist Please ensure you, the author, have gone...
The second argument must be a pointer type, otherwise it won't work as intended. ### Requires ### Supports
## Description fix some function names in comment ## Checklist - [ ] Changelog has been updated as necessary.
**What does this pull request do? Explain your changes. (required)** fix the `go vet ./...` warning: ```shell # github.com/livepeer/go-livepeer/trickle trickle/trickle_subscriber.go:145:4: the cancel function is not used on all paths (possible...
go vet ./... warning: ```shell # [github.com/Conflux-Chain/go-conflux-sdk/types/pos] types/pos/transaction_payload.go:16:2: struct field PublicKey repeats json tag "publicKey" also at transaction_payload.go:49 types/pos/transaction_payload.go:16:2: struct field VrfPublicKey repeats json tag "vrfPublicKey" also at transaction_payload.go:50 types/pos/transaction_payload.go:19:2:...
fix the misuse of unbuffered os.Signal channel as argument to signal.Notify