fisker Cheung comments

Results 1279 comments of


                                            fisker Cheung

Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters

We already made decision to not insert space. Problem here is where we can break if `--prose-wrap always` https://github.com/prettier/prettier/pull/11597#issuecomment-1192951382

Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters

Sorry for the delay, alpha release is mainly for plugins, this will be included in v3, don't worry.

Markdown[next branch]: Do not insert spaces between Chinese/Japanese & latin letters

> never add or remove whitespace between letters and punctuation. 👍

Remove 2nd argument pass to `Plugin.parse` function

Any thought on this?

Remove 2nd argument pass to `Plugin.parse` function

If we still want keep it, maybe we should change it to a Proxy? https://github.com/prettier/prettier/blob/e096ea7552c2aaec1883c7fdde4bd9f5283301bd/src/main/parser.js#L61-L74

Remove 2nd argument pass to `Plugin.parse` function

@thorn0 @sosukesuzuki In case you missed.

Remove 2nd argument pass to `Plugin.parse` function

Cheaper? We don't need map all keys.

Remove 2nd argument pass to `Plugin.parse` function

> if it isn't used by real-world plugins. Maybe it doesn't matter if plugin uses it or not, if plugin uses `options`, it will have to change, the `options` paramter...

Remove 2nd argument pass to `Plugin.parse` function

This is when it's added https://github.com/prettier/prettier/pull/1783/files#diff-54c345dc104dc19440f9c2482b7883df820e8b9b699fdd8fa07e2773e7197a29L22

Remove 2nd argument pass to `Plugin.parse` function

Let's pass an empty object in v3 (deprecate those getters), and remove the paramter in v4?