fisker Cheung comments

Results 1279 comments of


                                            fisker Cheung

npm版本与git版本不同步

跟我的问题是一样的 https://github.com/fex-team/fis3/issues/1280 vue没识别成文本这库也没人管了

自带uglify-js无法压缩(function(){})()这种js

跟forEach没关系，是箭头函数的问题，uglifyjs不支持的，uglify-es或者babel才行

PR #69 seems to be a breaking change in 0.5.8

I suggest release 1.0 for 0.57 2.0 for 0.58 then let glimmer team choose, will not break things

PR #69 seems to be a breaking change in 0.5.8

@rwjblue sorry to bother, but any solution?

Rule proposal: Prefer `Array.from(arr, mapFn)` over `Array.from(arr).map(mapFn)`

This rule may conflict with [`prefer-array-flat-map`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-array-flat-map.md), I'm not how will ESLint work if we enable both for following code ```js Array.from(foo).map(bar).flat() ```

Rule proposal: Forbid `!foo === bar`

That rule not checking this case, but I can make a proposal there.

Rule proposal: Forbid `!foo === bar`

Forgot to mention here, issue on ESLint codebase https://github.com/eslint/eslint/issues/14802, and seems they are going accept.

Rule proposal: Forbid `!foo === bar`

~Maybe we should also forbid `!foo in bar` and `!foo instanceof bar`.~ ~Rule name `no-negation-in-equality-check` won't fit.~ Sorry, `!foo in bar` and `!foo instanceof bar` already handled by [`no-unsafe-negation`](https://eslint.org/docs/latest/rules/no-unsafe-negation)

Rule proposal: Forbid `!foo === bar`

~`no-negated-binary-expression-left`?~ See previous comment