fisker Cheung comments

Results 1276 comments of


                                            fisker Cheung

[prefer-spread] comments are not preserved

One off-topic question, is this autofix? The rule should not know `Object.keys()` call return type, is this a suggestion fix?

Rule `text-encoding-identifier-case`: Change utf8 canonical to utf-8

Please add an option to allow both.

`prefer-type-error`: ignore error type check

@fregante Something wrong with the action?

`prefer-type-error`: ignore error type check

Ah, I should omit `unicorn/`, but it's still a little wired..

[`prefer-code-point`] doesn't report on `const fromCharCode = String.fromCharCode.bind(String)`

If someone wants to work on this, change this part https://github.com/sindresorhus/eslint-plugin-unicorn/blob/756dbbf0a359a139745b092a676f6e535cb85128/rules/prefer-code-point.js#L19-L26 to use `isMemberExpression` check and update related logic should work.

Try out v8 beta on various influential community repos

Prettier is ready, sir!

Try out v8 beta on various influential community repos

BTW, maybe we should also mention #8920 in https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/ somewhere?

Let's change the utils `isBooleanNode(node)` to `isInControlFlow(node)`

#1840 is not caused by `isBooleanNode` but because there is additional check https://github.com/sindresorhus/eslint-plugin-unicorn/blob/a5d5562fb084c8445f0d19f945694746b162dbe9/rules/explicit-length-check.js#L183-L189

Fix: Consistent formatting for NewExpression with type cast (#18406)

> I’ve read the [contributing guidelines](https://github.com/prettier/prettier/blob/main/CONTRIBUTING.md?rgh-link-date=2025-12-03T03%3A29%3A18Z). Please read.

Fix: Consistent formatting for NewExpression with type cast (#18406)

Thanks!