fisker Cheung comments

Results 1278 comments of


                                            fisker Cheung

`no-fn-reference-in-iterator` false positives on non-array methods

No , it's not about binding, it's about function parameter changes . see https://github.com/sindresorhus/eslint-plugin-unicorn/blob/master/docs/rules/no-fn-reference-in-iterator.md

`no-fn-reference-in-iterator` false positives on non-array methods

We don't even support `foo.map(lib.fn)` before #666 , you can check the code and PR description.

`no-fn-reference-in-iterator` false positives on non-array methods

> What if the linting error itself provides a hint such as: > > > If you think this is a false positive, disable this check with `// eslint-disable-next-line unicorn/no-fn-reference-in-iterator`...

[New] support eslint v9

What are we waiting for?

(docs) Replaced every incorrect usages of `bun exec` with `bunx`, `pnpm exec` with `pnpm`, and `yarn exec` with `yarn`

Please take a look at https://github.com/prettier/prettier/pull/17191

(docs) Replaced every incorrect usages of `bun exec` with `bunx`, `pnpm exec` with `pnpm`, and `yarn exec` with `yarn`

Would you like to update this PR accordingly? That one not respond for a long time.

(docs) Replaced every incorrect usages of `bun exec` with `bunx`, `pnpm exec` with `pnpm`, and `yarn exec` with `yarn`

I'm sorry, but `yarn exec`/`pnpm exec` (we should avoid downloading from npm) are correct, I sent https://github.com/prettier/prettier/pull/17647 instead.

Enhancement: Remove `errorOnUnknownASTType` option from `ParseOptions`

For Prettier, the main problem here is `errorOnUnknownASTType: true` still produces `TSJSDocAllType`, `TSJSDocUnknownType`, `TSJSDocNullableType`, and `TSJSDocNonNullableType`

Enhancement: Remove `errorOnUnknownASTType` option from `ParseOptions`

To be clear, I'm also fine with keeping this option , but I don't think we should make an exception for [`ts.SyntaxKind.JSDocFunctionType`](https://github.com/typescript-eslint/typescript-eslint/blob/4ad8a0713376e5b88c56997312861a2c8cb049ab/packages/typescript-estree/src/convert.ts#L3544).

util: update isError with new Error.isError

We should deprecate `.isError` like [`.isArray`](https://nodejs.org/api/util.html#utilisarrayobject)