Nicolas Iooss

(possible bug) variable str_special_imms is initialized twice in function str_special_imms

1

Hello, Thanks for sharing this great work! While reading the code of the disassembler, I stumbled upon these lines in function `get_str_uop_xxx_ustate_special_imms`: https://github.com/chip-red-pill/uCodeDisasm/blob/a69515f0f3790bc3706f6c051e9b06f6a0635973/glm_ucode_disasm/glm_ucode_disasm.py#L543-L547 The variable `str_special_imms` is reset after being...

Hello, When studying the instructions referenced in `misc/glm_msr_read_desc.txt`, I stumbled upon something odd. Some MSR use `chkproc: U3740`, others `chkproc: U3748`, and the associated instructions are decoded in exactly the...

Hello, While testing Pull Request https://github.com/WaterJuice/WjCryptLib/pull/7, `projects/WjCryptLibTest/WjCryptLibTest` was failing. Investing why led me to discovering a problem with the size of a stack buffer in the code which tests AES-CBC....

Hello, First, thank you for making this code public! It is quite helpful and it is nice to have cryptographic functions implemented in a way which does not require integrating...

Missing `state->address_step=3;` in `michelson_read_address`?

3

Hello, While reading the state machine in `src/operations.c` I am wondering how this code works: https://github.com/obsidiansystems/ledger-app-tezos/blob/58797b2f9606c5a30dd1ccc9e5b9962e45e10356/src/operations.c#L199-L213 More precisely after `case 0: ... state->address_step=1;` and `case 1: ... state->address_step=2;`, why is...

Strange code in attr_common_add_data

1

Hello, Currently, function `attr_common_add_data` contains: https://github.com/tpm2-software/tpm2-pkcs11/blob/90482e03c26c8c8d855a2c7297ad24d22dc99f47/src/lib/attrs.c#L523-L534 Adding `CKA_APPLICATION` twice is strange, and doing a `if (CKA_OBJECT_ID does not exist) { add CKA_APPLICATION }` seems also to be strange. This looks...

FreeRDP supports rdp2tcp out of the box since 2.0.0, thanks to https://github.com/FreeRDP/FreeRDP/pull/5396 . Document this in the README.

Hello, While trying to add type hints to many modules, I encountered an issue in https://github.com/chipsec/chipsec/blob/36ca6fa5a78433d26ca8adea622afce56cc15bf7/chipsec/hal/uefi.py#L352-L361 `self.cs.spi` does not exist. When trying to call this function with ```python # ......

## What does this PR do While trying to collect the ACK timestamps, it appeared `SOF_TIMESTAMPING_TX_ACK` was missing from `TimestampingFlag`. It was already added to `libc` a few years ago...

**Describe the bug** Several files refer to "Mercurity Security" (now part of HID Global) instead of "Mercury Security": https://github.com/rapid7/recog/blob/0ffcd3e0aa9041bc9d06db73e957d427d372d1d3/xml/http_servers.xml#L2047-L2049 https://github.com/rapid7/recog/blob/0ffcd3e0aa9041bc9d06db73e957d427d372d1d3/xml/x509_subjects.xml#L1135-L1137 https://github.com/rapid7/recog/blob/0ffcd3e0aa9041bc9d06db73e957d427d372d1d3/xml/x509_subjects.xml#L1146-L1148 **To Reproduce** Steps to reproduce the behavior: 1. Open...